On Fri, Nov 25, 2022 at 02:27:56PM +0100, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
Acked-by: Gabriel Somlo <gsomlo@xxxxxxxxx>
Thanks,
--G
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Karol Gugala <kgugala@xxxxxxxxxxxx>
> Cc: Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> Cc: Gabriel Somlo <gsomlo@xxxxxxxxx>
> Cc: Joel Stanley <joel@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-6.0.orig/drivers/tty/serial/Kconfig
> +++ linux-6.0/drivers/tty/serial/Kconfig
> @@ -1519,7 +1519,7 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
> config SERIAL_LITEUART
> tristate "LiteUART serial port support"
> depends on HAS_IOMEM
> - depends on OF || COMPILE_TEST
> + depends on OF
> depends on LITEX || COMPILE_TEST
> select SERIAL_CORE
> help
>
>
> --
> Jean Delvare
> SUSE L3 Support
