> -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: 2022年11月23日 0:56 > To: Sherry Sun <sherry.sun@xxxxxxx> > Cc: jirislaby@xxxxxxxxxx; michael@xxxxxxxx; jingchang.lu@xxxxxxxxxxxxx; > tomonori.sakita@xxxxxxxxxx; atsushi.nemoto@xxxxxxxxxx; linux- > serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux- > imx@xxxxxxx> > Subject: Re: [PATCH V2 1/5] tty: serial: fsl_lpuart: only enable Idle Line > Interrupt for non-dma case > > On Thu, Nov 10, 2022 at 04:17:24PM +0800, Sherry Sun wrote: > > For the lpuart driver, the Idle Line Interrupt Enable now is only > > needed for the CPU mode, so enable the UARTCTRL_ILIE at the correct > > place, and clear it when shutdown. > > > > Also need to configure the suitable UARTCTRL_IDLECFG, now the value is > > 0x7, represent 128 idle characters will trigger the Idle Line Interrupt. > > > > Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx> > > --- > > Changes in V2: > > 1. Use FIELD_PREP() and GENMASK() for easy access to UARTCTRL_IDLECFG > > fields as suggested by Ilpo. > > --- > > drivers/tty/serial/fsl_lpuart.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > This commit breaks the build for me as FIELD_PREP() does not seem to be > included properly :( > > Please fix up and resend. Hi Greg, It is strange that the build is pass at my side. But anyway, I will include the corresponding head files for FIELD_PREP/GENMASK and resend it. Sorry for the inconvenience. Best Regards Sherry
