On Mon, Nov 07, 2022 at 01:31:52PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 07, 2022 at 12:21:26PM +0200, Ilpo Järvinen wrote:
...
> Yep, I used to have something like draft of the below change locally.
> Thanks for putting it in shape and upstreamimg!
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
...
> > -static void __dma_rx_complete(void *param)
> > +static void __dma_rx_complete(struct uart_8250_port *p)
> > {
> > - struct uart_8250_port *p = param;
> > struct uart_8250_dma *dma = p->dma;
Btw, looking into my patch in archives I noticed that dma can also be passed as
a parameter...
...
> > +static void dma_rx_complete(void *param)
> > +{
> > + struct uart_8250_port *p = param;
> > + struct uart_8250_dma *dma = p->dma;
...since you have it already here.
> > + unsigned long flags;
> > +
> > + __dma_rx_complete(p);
--
With Best Regards,
Andy Shevchenko
