On Fri, Nov 4, 2022 at 12:23 PM <Tharunkumar.Pasumarthi@xxxxxxxxxxxxx> wrote: > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Sent: Monday, October 3, 2022 2:57 PM > > If you have similarities with 8250_pci, probably you need to split it to > > 8250_pcilib.c and share. (See how 8250_dw /8250_lpss are done in that > > sense.) > > All the functions used in 8250_pci1xxxx.c that have similarity with 8250_pci use registers > that are specific to our IP. The only function that can be moved to common library is the > setup_port. But, for that the first argument of setup_port must be changed to > 'struct pci_dev *dev' (priv->dev). Do you suggest doing this? So, you can create a common serial8250_setup_port(struct pci_dev *dev, ...) and call it from the static setup_port() inside 8250_pci.c. This way you won't introduce too many churn. -- With Best Regards, Andy Shevchenko
