On 26/10/2022 13.25, Ilpo Järvinen wrote:
On Tue, 25 Oct 2022, Martin Hundebøll wrote:
The 8250 module has been updated allow configurations with zero builtin
UART ports, so change the description of the parameter to reflect that.
Signed-off-by: Martin Hundebøll<martin@xxxxxxxxxx>
---
Change since v2:
* new patch
drivers/tty/serial/8250/8250_core.c | 3 ++-
drivers/tty/serial/8250/Kconfig | 10 +++++-----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index a8fbc2325244..3d8bf0296080 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1257,7 +1257,8 @@ module_param_hw(share_irqs, uint, other, 0644);
MODULE_PARM_DESC(share_irqs, "Share IRQs with other non-8250/16x50 devices (unsafe)");
module_param(nr_uarts, uint, 0644);
-MODULE_PARM_DESC(nr_uarts, "Maximum number of UARTs supported. (1-" __MODULE_STRING(CONFIG_SERIAL_8250_NR_UARTS) ")");
+MODULE_PARM_DESC(nr_uarts, "Number of built-in (non-discoverable) UARTs to initialize. (1-"
+ _MODULE_STRING(CONFIG_SERIAL_8250_NR_UARTS) ")");
This fails to build. You have dropped the second underscore for some
reason.
Running checkpatch after make is dangerous...
Shouldn't that 1- be also changed to 0- ?
Correct. In fact, it should be 0 - ARRAY_SIZE(old_serial_port) - 1.
// Martin
