> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Monday, October 3, 2022 2:57 PM > To: Kumaravel Thiagarajan - I21417 > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx> > Subject: Re: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power > management functions to quad-uart driver. > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > If you have similarities with 8250_pci, probably you need to split it to > 8250_pcilib.c and share. (See how 8250_dw /8250_lpss are done in that > sense.) Functions related to suspend and resume use registers specific to our IP which other drivers cannot use. I will move functions like pci1xxxx_set_divisor, pci1xxxx_get_divisor, pci1xxxx_setup_port and pci1xxxx_rs485_config to a new file. Thanks, Tharun Kumar P