Re: [PATCH 5.10 v2 1/2] serial: core: move RS485 configuration tasks from drivers into core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27.10.22 02:21, Dominique Martinet wrote:
> Greg Kroah-Hartman wrote on Wed, Oct 26, 2022 at 06:54:11PM +0200:
>> On Mon, Oct 17, 2022 at 02:17:36PM +0900, Dominique Martinet wrote:
>>> From: Lino Sanfilippo <LinoSanfilippo@xxxxxx>
>>>
>>> Several drivers that support setting the RS485 configuration via userspace
>>> implement one or more of the following tasks:
>>>
>>> - in case of an invalid RTS configuration (both RTS after send and RTS on
>>>   send set or both unset) fall back to enable RTS on send and disable RTS
>>>   after send
>>>
>>> - nullify the padding field of the returned serial_rs485 struct
>>>
>>> - copy the configuration into the uart port struct
>>>
>>> - limit RTS delays to 100 ms
>>>
>>> Move these tasks into the serial core to make them generic and to provide
>>> a consistent behaviour among all drivers.
>>>
>>> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>
>>> Link: https://lore.kernel.org/r/20220410104642.32195-2-LinoSanfilippo@xxxxxx
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> [ Upstream commit 0ed12afa5655512ee418047fb3546d229df20aa1 ]
>>> Signed-off-by: Daisuke Mizobuchi <mizo@xxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Dominique Martinet <dominique.martinet@xxxxxxxxxxxxxxxxx>
>>> ---
>>> Follow-up of https://lkml.kernel.org/r/20221017013807.34614-1-dominique.martinet@xxxxxxxxxxxxxxxxx
>>
>> I need a 5.15.y version of this series before I can take the 5.10.y
>> version.
>
> Thanks for the probing, I did not know about this rule (but it makes
> sense); I've just sent a 5.15 version:
> https://lkml.kernel.org/r/20221027001943.637449-1-dominique.martinet@xxxxxxxxxxxxxxxxx
>
> I'd really appreciate if Lino could take a look and confirm we didn't
> botch this too much -- we've tested the 5.10 version and it looks ok,
> but this is different enough from the original patch to warrant a check
> from the author.

Concerning the part I authored (patch 1) I do not see any changes, so

Acked-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>

However the part Lukas authored (patch 2) seems to be the one that has been adjusted
a lot, so maybe you rather/also want to have his ack?

Best Regards,
Lino







[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux