On Thu, 20 Oct 2022, Martin Hundebøll wrote: > > > On October 20, 2022 2:34:14 PM GMT+02:00, "Ilpo Järvinen" <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > >On Tue, 18 Oct 2022, Martin Hundebøll wrote: > > > >> The logic to find unused ports when registering new 8250 uart ports > >> searches only up to CONFIG_SERIAL_8250_RUNTIME_UART, which forces users > >> of external 8250 ports to increase the number of runtime ports > >> artificially. > >> > >> Fix this by initializing each allocated port structure with basic > >> settings like line number and uart operation callbacks, and by searching > >> the entire array of allocated ports to find an unused one. > > > >So nr_uarts no longer means "Maximum number of UARTs supported." ? > >Perhaps it should be reworded too. > > > > It never did. Confusingly, the module parameter name (nr_uarts) > corresponds to CONFIG_SERIAL_8250_RUNTIME_UARTS, and controls the number > of built-in (non-discoverable) ports. The other config, > CONFIG_SERIAL_8250_NR_UARTS, controls the maximum number of ports. > > We cannot change the module parameter name, so I'm not sure if we should > map it to another static variable in the source? I meant that its description should be changed to match what it really does. -- i.
