On Wed, Oct 19, 2022 at 12:11:12PM +0300, Ilpo Järvinen wrote: > Take advantage of the new uart_xmit_advance() helper. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/sc16is7xx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > index 524921360ca7..39f92eb1e698 100644 > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -686,13 +686,10 @@ static void sc16is7xx_handle_tx(struct uart_port *port) > } > to_send = (to_send > txlen) ? txlen : to_send; > > - /* Add data to send */ > - port->icount.tx += to_send; > - > /* Convert to linear buffer */ > for (i = 0; i < to_send; ++i) { > s->buf[i] = xmit->buf[xmit->tail]; > - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > + uart_xmit_advance(port, 1); > } > > sc16is7xx_fifo_write(port, to_send); > -- > 2.30.2 > -- With Best Regards, Andy Shevchenko