On 2022-09-24 at 06:00:19 -0700, Tom Rix wrote: > > On 9/23/22 5:17 AM, matthew.gerlach@xxxxxxxxxxxxxxx wrote: > > From: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@xxxxxxxxxxxxxxx> > > > > Moving the DFH register offset and register definitions from > > drivers/fpga/dfl.h to include/linux/dfl.h. These definitions > > need to be accessed by dfl drivers that are outside of > > drivers/fpga. > > This comment does not match what is done. > > A move, a change in names and the introduction new defines. > > I am not sure if moving these #defines is the best approach, the later use > of the in the uart with FIELD_GET's i think should be wrapped as functions > and these functions exported rather than the #defines. I agree, to play with all domains across kernel, we'd better not expose too much bus specific details. Thanks, Yilun
