On Sat, Sep 24, 2022 at 01:57:29PM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote: > > The readx_poll_timeout() consolidates the necessary code under > > macro. Replace current code with it. ... > > +#include <vdso/time64.h> > > Ick, just for USEC_PER_MSEC? That should be in units.h, not burried in > a vdso-only .h file. This feels wrong, sorry. Why are you asking me about this? It was not my choice and it was made a couple of years ago (see [1]). As a solution I can just drop using that constant in v3. [1]: b72a9c5e023b ("linux/time64.h: Extract common header for vDSO") -- With Best Regards, Andy Shevchenko