On Fri, Sep 09, 2022 at 12:12:58PM +0300, Andy Shevchenko wrote:
> uart_xmit_advance() provides a common way on how to advance
> the Tx queue. Use it for the sake of unification and robustness.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index b43894e15b07..4f4d878dc2fc 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -984,9 +984,7 @@ static void omap_8250_dma_tx_complete(void *param)
>
> dma->tx_running = 0;
>
> - xmit->tail += dma->tx_size;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> - p->port.icount.tx += dma->tx_size;
> + uart_xmit_advance(&p->port, dma->tx_size);
>
> if (priv->delayed_restore) {
> priv->delayed_restore = 0;
> --
> 2.35.1
>
Breaks the build :(
