Re: [PATCH v4 10/10] tty: serial: use uart_port_tx_limited()

[Jiri Slaby <jirislaby@xxxxxxxxxx>]

On 20. 09. 22, 11:19, Ilpo Järvinen wrote:
> One improvement suggestion below.
>
> > diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
> > index 23f339757894..f224f5141726 100644
> > --- a/drivers/tty/serial/altera_jtaguart.c
> > +++ b/drivers/tty/serial/altera_jtaguart.c
> > @@ -137,39 +137,17 @@ static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp)
> >   static void altera_jtaguart_tx_chars(struct altera_jtaguart *pp)
...
> > +	space = readl(port->membase + ALTERA_JTAGUART_CONTROL_REG);
> > +	space &= ALTERA_JTAGUART_CONTROL_WSPACE_MSK;
> > +	space >>= ALTERA_JTAGUART_CONTROL_WSPACE_OFF;
>
> This is FIELD_GET(ALTERA_JTAGUART_CONTROL_WSPACE_MSK, ...) & then allows
> killing ALTERA_JTAGUART_CONTROL_WSPACE_OFF. I'd probably do it in a
> separate patch though.

Right. Prepared for v5.

thanks,
--
js
suse labs