On Tue, 20 Sep 2022, Jiri Slaby wrote: > The condition in __serial_lpc32xx_tx()'s loop is barely readable. > Extract it to a separate function. This will make the cleanup in the > next patches easier too. > > Cc: Vladimir Zapolskiy <vz@xxxxxxxxx> > Cc: <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> I noticed that wait_for_xmit_ready() uses < 32 for the similar check which seems fishy... -- i.