Re: [PATCH] serial: omap: Disallow RS-485 if rts-gpio is not specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 11, 2022 at 11:25 AM Lukas Wunner <lukas@xxxxxxxxx> wrote:

> The serial-omap driver requires an rts-gpio for RS-485 to work.
> Historically it has allowed enabling RS-485 even if no rts-gpio was
> specified in the device tree.
>
> That doesn't make any sense, so disable RS-485 on probe if rts-gpio is
> missing and disallow user space from enabling it.
>
> Three NULL pointer checks for up->rts_gpiod can be dropped as a result,
> simplifying the driver slightly.
>
> Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>

LooksGoodToMe
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux