On 06/09/2022 15:55, Sergiu Moga wrote: > FLEXCOM, among other functionalities, has the ability to offer the USART > serial communication protocol. To have the FLEXCOM binding properly > validate its USART children nodes, we must reference the correct binding. > To differentiate between the SPI of FLEXCOM and the SPI of USART in SPI > mode, use the clock-names property, since the latter's respective > property is supposed to contain the "usart" string. > > Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> > --- > > > v1 -> v2: > - Nothing > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > index 0db0f2728b65..b5fb509f07ec 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > @@ -72,13 +72,21 @@ properties: > > patternProperties: > "^serial@[0-9a-f]+$": > - type: object > + $ref: /schemas/serial/atmel,at91-usart.yaml > description: > - Child node describing USART. See atmel-usart.txt for details > - of USART bindings. > + Child node describing USART. > > "^spi@[0-9a-f]+$": > - $ref: /schemas/spi/atmel,at91rm9200-spi.yaml > + allOf: > + - if: > + properties: > + clock-names: > + contains: > + const: usart Devices are not different because they have or have not clock. Devices are different... because they are simply different models, so this should be different compatible. Best regards, Krzysztof
