On Tue, Sep 06, 2022 at 12:48:01PM +0200, Jiri Slaby wrote: > This series introduces DEFINE_UART_PORT_TX_HELPER + > DEFINE_UART_PORT_TX_HELPER_LIMITED TX helpers. See PATCH 2/4 for the > details. Comments welcome. > > Then it switches drivers to use them. First, to > DEFINE_UART_PORT_TX_HELPER() in 3/4 and then > DEFINE_UART_PORT_TX_HELPER_LIMITED() in 4/4. > > The diffstat of patches 3+4 is as follows: > 26 files changed, 191 insertions(+), 823 deletions(-) > which appears to be nice. Not really. This is horrid. Quality can't be measured in LoC (only). The resulting code is unreadable. And for no good reason. [ And note that you're "saving" something like 20 lines per driver: 12 files changed, 84 insertions(+), 349 deletions(-) ] NAK Johan
