On Thu, 1 Sep 2022, Jiri Slaby wrote: > DEFINE_UART_PORT_TX_HELPER_LIMITED() is a new helper to send characters > to the device. Use it in these drivers. > > mux.c also needs to define tx_done(). But I'm not sure if the driver > really wants to wait for all the characters to dismiss from the HW fifo > at this code point. Hence I marked this as FIXME. Indeed, it seems odd. This change looked good to me but I'll give my rev-by only after seeing the next version. -- i. > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > Cc: Russell King <linux@xxxxxxxxxxxxxxx> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> > Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx > Cc: "Pali Rohár" <pali@xxxxxxxxxx> > Cc: Kevin Cernekee <cernekee@xxxxxxxxx> > Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx> > Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx> > Cc: Orson Zhai <orsonzhai@xxxxxxxxx> > Cc: Baolin Wang <baolin.wang7@xxxxxxxxx> > Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx> > Cc: Patrice Chotard <patrice.chotard@xxxxxxxxxxx> > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
