On Thu, 25 Aug 2022, Ilpo Järvinen wrote: > Use the normal UART_XMIT_SIZE directly. I gather this is to fix a potential inconsistency with the size of the buffer allocated by the serial core (though in reality this driver will only be used with 4KiB-page systems), right? If so, then please state it in the change description. Also I'd rather: #define DZ_WAKEUP_CHARS UART_XMIT_SIZE and there's no need to include <linux/serial_core.h> in dz.h as the driver itself already does that (and dz.h is an auxiliary private header). Thanks for your submission. Maciej
