On Fri, Aug 19, 2022 at 2:04 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > No need to check non-zeroness first and then clear. Just set to zero > unconditionally. Harmless micro-optimization, Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > --- > drivers/tty/serial/8250/8250_dma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c > index a8dba4a0a8fb..d99020fd3427 100644 > --- a/drivers/tty/serial/8250/8250_dma.c > +++ b/drivers/tty/serial/8250/8250_dma.c > @@ -107,8 +107,7 @@ int serial8250_tx_dma(struct uart_8250_port *p) > > dma_async_issue_pending(dma->txchan); > serial8250_clear_THRI(p); > - if (dma->tx_err) > - dma->tx_err = 0; > + dma->tx_err = 0; > > return 0; > err: > > -- > tg: (568035b01cfb..) 8250dma/tx_err-clear-unconditionally (depends on: tty-next) -- With Best Regards, Andy Shevchenko
