RE: [PATCH v3] tty: serial: samsung_tty: loopback mode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "'Marek Szyprowski'" <m.szyprowski@xxxxxxxxxxx>, "'Krzysztof Kozlowski'" <krzysztof.kozlowski@xxxxxxxxxx>, "'Greg Kroah-Hartman'" <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [PATCH v3] tty: serial: samsung_tty: loopback mode support
From: "Chanho Park" <chanho61.park@xxxxxxxxxxx>
Date: Wed, 13 Jul 2022 08:55:32 +0900
Cc: "'Jiri Slaby'" <jirislaby@xxxxxxxxxx>, "'Alim Akhtar'" <alim.akhtar@xxxxxxxxxxx>, "'Hector Martin'" <marcan@xxxxxxxxx>, "'Jaewon Kim'" <jaewon02.kim@xxxxxxxxxxx>, "'Vincent Whitchurch'" <vincent.whitchurch@xxxxxxxx>, "'Ilpo Järvinen'" <ilpo.jarvinen@xxxxxxxxxxxxxxx>, <linux-samsung-soc@xxxxxxxxxxxxxxx>, <linux-serial@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
Cms-type: 102P
In-reply-to: <caa266c1-aecc-31c4-75f5-b5061444b446@samsung.com>
References: <CGME20220629004356epcas2p408afcd3d19d926a86d98e887e25e93bc@epcas2p4.samsung.com> <20220629004141.51484-1-chanho61.park@samsung.com> <4fb8c922-08aa-2ee3-8073-95b8a26bf5db@samsung.com> <000001d89588$936d14c0$ba473e40$@samsung.com> <caa266c1-aecc-31c4-75f5-b5061444b446@samsung.com>

> Right. The problem is elsewhere. You used rd_reg(port, S3C2410_UCON)
> instead of rd_regl(port, S3C2410_UCON) what always zeroed upper bits. I
> will send a fix in a few minutes.

Oops. You're right. Thanks for pointing it out and send the fix.

Best Regards,
Chanho Park

References:
- [PATCH v3] tty: serial: samsung_tty: loopback mode support
  - From: Chanho Park
- Re: [PATCH v3] tty: serial: samsung_tty: loopback mode support
  - From: Marek Szyprowski
- RE: [PATCH v3] tty: serial: samsung_tty: loopback mode support
  - From: Chanho Park
- Re: [PATCH v3] tty: serial: samsung_tty: loopback mode support
  - From: Marek Szyprowski

Prev by Date: Re: [Regression] CH341 USB-serial converter passes data in 32 byte chunks
Next by Date: RE: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl()
Previous by thread: Re: [PATCH v3] tty: serial: samsung_tty: loopback mode support
Next by thread: [PATCH v2] tty: serial: samsung_tty: support more than 4 uart ports
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]