Hi Lino, I love your patch! Perhaps something to improve: [auto build test WARNING on 7e5b4322cde067e1d0f1bf8f490e93f664a7c843] url: https://github.com/intel-lab-lkp/linux/commits/Lino-Sanfilippo/Fixes-and-cleanup-for-RS485/20220710-230624 base: 7e5b4322cde067e1d0f1bf8f490e93f664a7c843 config: hexagon-randconfig-r041-20220710 (https://download.01.org/0day-ci/archive/20220710/202207102355.Y27cvu6y-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6ce63e267aab79ca87bf63453d34dd3909ab978d) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/846f02e6da9692810ed632dd72f45af667c3cc67 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Lino-Sanfilippo/Fixes-and-cleanup-for-RS485/20220710-230624 git checkout 846f02e6da9692810ed632dd72f45af667c3cc67 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/tty/serial/serial_core.c:1364:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!rs485->flags & SER_RS485_ENABLED) ^ ~ drivers/tty/serial/serial_core.c:1364:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!rs485->flags & SER_RS485_ENABLED) ^ ( ) drivers/tty/serial/serial_core.c:1364:6: note: add parentheses around left hand side expression to silence this warning if (!rs485->flags & SER_RS485_ENABLED) ^ ( ) 1 warning generated. vim +1364 drivers/tty/serial/serial_core.c 1360 1361 static void uart_set_rs485_termination(struct uart_port *port, 1362 const struct serial_rs485 *rs485) 1363 { > 1364 if (!rs485->flags & SER_RS485_ENABLED) 1365 return; 1366 1367 gpiod_set_value_cansleep(port->rs485_term_gpio, 1368 !!(rs485->flags & SER_RS485_TERMINATE_BUS)); 1369 } 1370 -- 0-DAY CI Kernel Test Service https://01.org/lkp
