RE: [PATCH 4/4] tty: n_gsm: fix missing corner cases in gsmld_poll()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > @@ -3051,14 +3051,20 @@ static __poll_t gsmld_poll(struct tty_struct *tty, struct file *file,
> >   	__poll_t mask = 0;
> >   	struct gsm_mux *gsm = tty->disc_data;
> >   
> > +	if (!gsm)
> > +		return EPOLLHUP;
> 
> Hmm, how can this happen? It's a tty bug if it calls ld ops after NULLing
> disc_data.

I can remove this check if it is redundant. Should I?

Best regards,
Daniel Starke




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux