Re: [PATCH v9 4/6] serial: take termios_rwsem for ->rs485_config() & pass termios as param

To: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Vladimir Zapolskiy <vz@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Richard Genoud <richard.genoud@xxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, NXP Linux Team <linux-imx@xxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v9 4/6] serial: take termios_rwsem for ->rs485_config() & pass termios as param
From: Jiri Slaby <jirislaby@xxxxxxxxxx>
Date: Mon, 4 Jul 2022 08:56:04 +0200
Cc: Lukas Wunner <lukas@xxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Lino Sanfilippo <LinoSanfilippo@xxxxxx>
In-reply-to: <60678c81-27bf-6f37-bae5-ccc91d714204@kernel.org>
References: <20220624204210.11112-1-ilpo.jarvinen@linux.intel.com> <20220624204210.11112-5-ilpo.jarvinen@linux.intel.com> <60678c81-27bf-6f37-bae5-ccc91d714204@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 04. 07. 22, 8:51, Jiri Slaby wrote:

Anyway, I'm not sure I buy the above. Why is termios_rwsem needed toalter ADDRB?


Nevermind, reading patch 5/6 gives a clue.

--
js
suse labs

References:
- [PATCH v9 0/6] Add RS485 9th bit addressing mode support to DW UART
  - From: Ilpo Järvinen
- [PATCH v9 4/6] serial: take termios_rwsem for ->rs485_config() & pass termios as param
  - From: Ilpo Järvinen
- Re: [PATCH v9 4/6] serial: take termios_rwsem for ->rs485_config() & pass termios as param
  - From: Jiri Slaby