RE: [PATCH v2] tty: serial: samsung_tty: loopback mode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Internal loopback mode can be supported by setting UCON register's
> > Loopback Mode bit. The mode & bit can be supported since
> > s3c2410 and later SoCs. The prefix of LOOPBACK / BIT(5) naming should
> > be also changed to S3C2410_ to avoid confusion.
> >
> > We can test it by linux-serial-test program with -k option. The tool
> > will set TIOCM_LOOP mode when the option is specified.
> > -k, --loopback     Use internal hardware loop back
> >
> > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Thanks for your review.

> 
> You should have included Krzysztof's Reviewed-by when you sent this next
> version so that it won't get lost.

I thought the codes have been changed since v1 so I'm not convinced I can
put his R-B tag.

> 
> I suspect Greg will again complain that you didn't address his comment
> about the out of the place "-k, --loopback ..." line.

The commit messages seems to be not necessary. I'll remove them next patch.

Best Regards,
Chanho Park






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux