On Mon, Jun 27, 2022 at 12:23:53PM +0900, Chanho Park wrote: > Internal loopback mode can be supported by setting > S3C2443_UCON_LOOPBACK bit. The mode & bit can be supported since > s3c2410 and later SoCs. We can test it by linux-serial-test program[1] > with -k option. It will set TIOCM_LOOP mode during test. > > -k, --loopback Use internal hardware loop back I do not understand this line in the changelog text, what is it for? > > [1]: https://github.com/cbrake/linux-serial-test > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> Our tools require a blank line before the signed-off-by line. Did you not get a warning when checking this patch before sending it out? Also, no need for a footnote in a changelog that is so short, just put the link in the body of the text itself. thanks, greg k-h
