On 22.06.22 at 19:06, Andy Shevchenko wrote: > On Wed, Jun 22, 2022 at 05:46:53PM +0200, Lino Sanfilippo wrote: >> From: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> >> >> In serial8250_em485_config() the termination GPIO is set with the uart_port >> spinlock held. This is an issue if setting the GPIO line can sleep (e.g. >> since the concerning GPIO expander is connected via SPI or I2C). >> >> Fix this by setting the termination line outside of the uart_port spinlock >> in the serial core. > > This doesn't describe that this patch is actually changing GPIO to support > sleep mode. So, it doesn't fix anything. Please rephrase the commit message > accordingly. Good point, I will adjust the commit message in the next version. >> This also makes setting the termination GPIO generic for all uart drivers. > > UART > Right, upper letters should be used. Thanks a lot for the review! Regards, Lino
