Hi Krzysztof, On Mon, 20 Jun 2022 at 11:21, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 19/06/2022 17:12, Tomer Maimon wrote: > > Add binding for the Arbel BMC NPCM8XX Clock controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > --- > > .../bindings/clock/nuvoton,npcm845-clk.yaml | 49 +++++++++++++++++++ > > .../dt-bindings/clock/nuvoton,npcm8xx-clock.h | 49 +++++++++++++++++++ > > 2 files changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > create mode 100644 include/dt-bindings/clock/nuvoton,npcm8xx-clock.h > > > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..3d4fddc090ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NPCM8XX Clock Controller Binding > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@xxxxxxxxx> > > + > > +description: | > > + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which > > + generates and supplies clocks to all modules within the BMC. > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm845-clk > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + description: > > + See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full > > + list of NPCM8XX clock IDs. > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > Use same quotes through your patchset - either " or '. Do not mix. > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + ahb { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + clock-controller@f0801000 { > > + compatible = "nuvoton,npcm845-clk"; > > + reg = <0x0 0xf0801000 0x0 0x1000>; > > + #clock-cells = <1>; > > + }; > > + }; > > +... > > diff --git a/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h > > new file mode 100644 > > index 000000000000..e5cce08b00e1 > > --- /dev/null > > +++ b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h > > @@ -0,0 +1,49 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > My comment about filename is still waiting to be resolved. I asked for > same filename as bindings in v1. Right, forgot to modify the file name will be done in next version. > > https://lore.kernel.org/all/CAP6Zq1gXEqqquKzxTHoxYnvh2LCGt-ES+k=aX61FKyHW5WB62w@xxxxxxxxxxxxxx/ > > I am still going to NAK it if it is not implemented. > > Best regards, > Krzysztof Best regards, Tomer
