Hello Tomer and Krzysztof, On Wed, Jun 08, 2022 at 12:03:00PM +0200, Krzysztof Kozlowski wrote: > On 08/06/2022 11:56, Tomer Maimon wrote: > > Add binding for the Arbel BMC NPCM8XX Clock controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > --- [...] > > + clocks: > > + items: > > + - description: 25M reference clock > > + - description: CPU reference clock > > + - description: MC reference clock > > + > > + clock-names: > > + items: > > + - const: refclk > > + - const: sysbypck > > + - const: mcbypck > > + > > I asked what is the suffix about and you replied "ck"... ok, so let's > make clear. This should be: > > items: > - const: ref > - const: sysbyp > - const: mcbyp > > or something similar, without the same suffix all over. A bit of a side note on these names: To make the binding as easy to understand as possible, I think it would help to have every part of the clock-names reflected in corresponding clock description: - sysbypck: presumably means system bypass clock - mcbypck: presumably means memory controller bypass clock As it currently is in the patch, the "byp" part stays unexplained and unmentioned in the descriptions. Thanks, Jonathan
Attachment:
signature.asc
Description: PGP signature
