Re: [PATCH 02/36] tty/vt: consolemap: rename and document struct uni_pagedir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07. 06. 22, 14:36, Ilpo Järvinen wrote:
On Tue, 7 Jun 2022, Jiri Slaby wrote:

struct uni_pagedir contains 32 unicode page directories, so the name of
the structure is a bit misleading. Rename the structure to uni_pagedict,
so it looks like this:
struct uni_pagedict
   -> 32 page dirs
      -> 32 rows
        -> 64 glyphs

Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
---

The rename looks incomplete:

  drivers/tty/vt/consolemap.c    | 47 ++++++++++++++++++++--------------
  drivers/video/console/vgacon.c |  4 +--
  include/linux/console_struct.h |  6 ++---
  3 files changed, 33 insertions(+), 24 deletions(-)

vs

$ git grep -l vc_uni_pagedir
drivers/tty/vt/consolemap.c
drivers/tty/vt/vt.c
drivers/usb/misc/sisusbvga/sisusb_con.c
drivers/video/console/vgacon.c
drivers/video/fbdev/core/fbcon.c
include/linux/console_struct.h

I renamed only the type, not the variables/members. Maybe the latter makes sense too. I will do that as a follow-up patch.

thanks,
--
js
suse labs



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux