On Tue, Jun 7, 2022 at 11:58 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Jun 7, 2022 at 7:42 AM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote: > > On 06. 06. 22, 16:35, Andy Shevchenko wrote: > > > On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <jslaby@xxxxxxx> wrote: > > >> > > >> For a long time, we generate unicode tables using loadkeys. So fix > > >> Makefile to use that flag too. > > > > > > generated > > > > We still do, but I didn't even know there is even a rule for that ;). > > I understand, but here is English stylistics like this. You need to > use past ind. or present perfect ("for a long time" dictates that). Okay, now even more explanation, present perfect should be used here. we have generated -- With Best Regards, Andy Shevchenko