Re: [PATCH 3/6] serial: core: fully suppress raising DTR & RTS on open if manual_rtsdtr

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, May 28, 2022 at 9:53 PM Mychaela N. Falconia
<falcon@xxxxxxxxxxxxxxx> wrote:
>
> When manual_rtsdtr sysfs attribute is written as 1,
> TTY_PORT_MANUAL_RTSDTR is set, and the call to raise DTR & RTS in
> tty_port_raise_dtr_rts() is suppressed.  However, there is one other
> place where these signals are also raised on open: uart_port_startup()
> in drivers/tty/serial/serial_core.c - this other point of raising
> DTR & RTS also needs to be suppressed if TTY_PORT_MANUAL_RTSDTR is set.

...

> -               if (init_hw && C_BAUD(tty))
> +               if (init_hw && !tty_port_manual_rtsdtr(&state->port) &&
> +                   C_BAUD(tty))
>                         uart_port_dtr_rts(uport, 1);
>         }

As per patch 1, I would put the custom flag check first.

-- 
With Best Regards,
Andy Shevchenko