On 22/05/2022 17:50, Tomer Maimon wrote:
> This adds initial device tree support for the
> Nuvoton NPCM845 Board Management controller (BMC) SoC family.
Thank you for your patch. There is something to discuss/improve.
>
> The NPCM845 based quad-core Cortex-A35 ARMv8 architecture and
> have various peripheral IPs.
>
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/Makefile | 1 +
> .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 197 ++++++++++++++++++
> .../boot/dts/nuvoton/nuvoton-npcm845.dtsi | 77 +++++++
> 3 files changed, 275 insertions(+)
> create mode 100644 arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> create mode 100644 arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
>
> diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
> index 1ba04e31a438..7b107fa7414b 100644
> --- a/arch/arm64/boot/dts/Makefile
> +++ b/arch/arm64/boot/dts/Makefile
> @@ -19,6 +19,7 @@ subdir-y += lg
> subdir-y += marvell
> subdir-y += mediatek
> subdir-y += microchip
> +subdir-y += nuvoton
> subdir-y += nvidia
> subdir-y += qcom
> subdir-y += realtek
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> new file mode 100644
> index 000000000000..19c672ecfee7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -0,0 +1,197 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2021 Nuvoton Technology tomer.maimon@xxxxxxxxxxx
> +
> +#include <dt-bindings/clock/nuvoton,npcm8xx-clock.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + interrupt-parent = <&gic>;
> +
> + /* external reference clock */
> + clk_refclk: clk-refclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>
This is not a property of a SoC, but board.
> + clock-output-names = "refclk";
> + };
> +
> + /* external reference clock for cpu. float in normal operation */
> + clk_sysbypck: clk-sysbypck {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <1000000000>;
This is not a property of a SoC, but board.
> + clock-output-names = "sysbypck";
> + };
> +
> + /* external reference clock for MC. float in normal operation */
> + clk_mcbypck: clk-mcbypck {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <1050000000>;
This is not a property of a SoC, but board.
> + clock-output-names = "mcbypck";
> + };
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + compatible = "simple-bus";
> + interrupt-parent = <&gic>;
> + ranges;
> +
> + gcr: gcr@f0800000 {
Generic node names. I guess it is system-controller?
> + compatible = "nuvoton,npcm845-gcr", "syscon",
> + "simple-mfd";
> + reg = <0x0 0xf0800000 0x0 0x1000>;
> + };
> +
> + gic: interrupt-controller@dfff9000 {
> + compatible = "arm,gic-400";
> + reg = <0x0 0xdfff9000 0x0 0x1000>,
> + <0x0 0xdfffa000 0x0 0x2000>,
> + <0x0 0xdfffc000 0x0 0x2000>,
> + <0x0 0xdfffe000 0x0 0x2000>;
> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + #address-cells = <0>;
> + ppi-partitions {
> + ppi_cluster0: interrupt-partition-0 {
> + affinity = <&cpu0 &cpu1 &cpu2 &cpu3>;
> + };
> + };
> + };
> + };
> +
> + ahb {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + compatible = "simple-bus";
> + interrupt-parent = <&gic>;
> + ranges;
> +
> + rstc: rstc@f0801000 {
Generic node names.
> + compatible = "nuvoton,npcm845-reset";
> + reg = <0x0 0xf0801000 0x0 0x78>;
> + #reset-cells = <2>;
> + syscon = <&gcr>;
> + };
> +
> + clk: clock-controller@f0801000 {
> + compatible = "nuvoton,npcm845-clk";
> + #clock-cells = <1>;
> + reg = <0x0 0xf0801000 0x0 0x1000>;
> + clock-names = "refclk", "sysbypck", "mcbypck";
> + clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>;
> + };
> +
> + apb {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + interrupt-parent = <&gic>;
> + ranges = <0x0 0x0 0xf0000000 0x00300000>,
> + <0xfff00000 0x0 0xfff00000 0x00016000>;
> +
> + timer0: timer@8000 {
> + compatible = "nuvoton,npcm845-timer";
> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x8000 0x1C>;
> + clocks = <&clk_refclk>;
> + clock-names = "refclk";
> + };
> +
> + serial0: serial@0 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x0 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial1: serial@1000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x1000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial2: serial@2000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x2000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial3: serial@3000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x3000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial4: serial@4000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x4000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial5: serial@5000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x5000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + serial6: serial@6000 {
> + compatible = "nuvoton,npcm845-uart";
> + reg = <0x6000 0x1000>;
> + clocks = <&clk NPCM8XX_CLK_UART>;
> + interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +
> + watchdog0: watchdog@801c {
> + compatible = "nuvoton,npcm845-wdt";
> + interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x801c 0x4>;
> + status = "disabled";
> + clocks = <&clk_refclk>;
> + syscon = <&gcr>;
> + };
> +
> + watchdog1: watchdog@901c {
> + compatible = "nuvoton,npcm845-wdt";
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x901c 0x4>;
> + status = "disabled";
> + clocks = <&clk_refclk>;
> + syscon = <&gcr>;
> + };
> +
> + watchdog2: watchdog@a01c {
> + compatible = "nuvoton,npcm845-wdt";
> + interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0xa01c 0x4>;
> + status = "disabled";
> + clocks = <&clk_refclk>;
> + syscon = <&gcr>;
> + };
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
> new file mode 100644
> index 000000000000..900cee112251
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
> @@ -0,0 +1,77 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2021 Nuvoton Technology tomer.maimon@xxxxxxxxxxx
> +
> +#include "nuvoton-common-npcm8xx.dtsi"
> +
> +/ {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + interrupt-parent = <&gic>;
You do not have gic here, so it's not correct. Do not reference nodes
outsides of the file.
> +
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a35";
> + clocks = <&clk NPCM8XX_CLK_CPU>;
> + reg = <0x0 0x0>;
Why do you have two address cells? A bit more complicated and not
necessary, I think.
> + next-level-cache = <&l2>;
> + enable-method = "psci";
> + };
> +
> + cpu1: cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a35";
> + clocks = <&clk NPCM8XX_CLK_CPU>;
> + reg = <0x0 0x1>;
> + next-level-cache = <&l2>;
> + enable-method = "psci";
> + };
> +
> + cpu2: cpu@2 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a35";
> + clocks = <&clk NPCM8XX_CLK_CPU>;
> + reg = <0x0 0x2>;
> + next-level-cache = <&l2>;
> + enable-method = "psci";
> + };
> +
> + cpu3: cpu@3 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a35";
> + clocks = <&clk NPCM8XX_CLK_CPU>;
> + reg = <0x0 0x3>;
> + next-level-cache = <&l2>;
> + enable-method = "psci";
> + };
> +
> + l2: l2-cache {
> + compatible = "cache";
Is this a real compatible? What bindings are you using here?
> + };
> + };
> +
> + arm-pmu {
> + compatible = "arm,cortex-a35-pmu";
> + interrupts = <GIC_SPI 242 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
Weird indentation.
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> + };
> +};
Best regards,
Krzysztof
