Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/17/22 7:07 AM, Ilpo Järvinen wrote:
> BRKINT is within c_iflag rather than c_cflag.
> 
> Cc: Sean Anderson <sean.anderson@xxxxxxxx>
> Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parameters)
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/uartlite.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 007db67292a2..880e2afbb97b 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port, struct ktermios *termios,
>  	struct uartlite_data *pdata = port->private_data;
>  
>  	/* Set termios to what the hardware supports */
> -	termios->c_cflag &= ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE);
> +	termios->c_iflag &= ~BRKINT;
> +	termios->c_cflag &= ~(CSTOPB | PARENB | PARODD | CSIZE);
>  	termios->c_cflag |= pdata->cflags & (PARENB | PARODD | CSIZE);
>  	tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
>  
> 

Reviewed-by: Sean Anderson <sean.anderson@xxxxxxxx>



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux