Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote: >> On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote: >> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: >> > > We may convert the GPT driver to use fwnode API for the sake >> > > of consistency of the used APIs inside the driver. >> > >> > I'm not sure about this one. >> > >> > It's more consistent to use fwnode in this driver, but it's very >> > inconsistent with the rest of the powerpc code. We have basically no >> > uses of the fwnode APIs at the moment. >> >> Fair point! >> >> > It seems like a pretty straight-forward conversion, but there could >> > easily be a bug in there, I don't have any way to test it. Do you? >> >> Nope, only compile testing. The important part of this series is to >> clean up of_node from GPIO library, so since here it's a user of >> it I want to do that. This patch is just ad-hoc conversion that I >> noticed is possible. But there is no any requirement to do so. >> >> Lemme drop this from v3. > > I just realize that there is no point to send a v3. You can just apply > first 3 patches. Or is your comment against entire series? No, my comment is just about this patch. I don't mind converting to new APIs when it's blocking some other cleanup. But given the age of this code I think it's probably better to just leave the rest of it as-is, unless someone volunteers to test it. So yeah I'll just take patches 1-3 of this v2 series, no need to resend. cheers