> > static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) > > { > > + int ret = 0; > > Why is the initialization needed? You can as well declare the variable only inside the if below. You are right, this was unneeded. But this patch was already included in the tty-linus branch. Shall I resubmit it nevertheless? Best regards, Daniel Starke