On Fri, Apr 29, 2022 at 01:44:18PM +0530, Shubhrajyoti Datta wrote:
> Add a check for the return value of runtime get_sync calls.
>
> Addresses-Coverity: Event check_return.
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> ---
> drivers/tty/serial/xilinx_uartps.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 8f15fe24a0eb..868f4e587263 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1100,13 +1100,17 @@ static void cdns_uart_poll_put_char(struct uart_port *port, unsigned char c)
> static void cdns_uart_pm(struct uart_port *port, unsigned int state,
> unsigned int oldstate)
> {
> + int ret;
> +
> switch (state) {
> case UART_PM_STATE_OFF:
> pm_runtime_mark_last_busy(port->dev);
> pm_runtime_put_autosuspend(port->dev);
> break;
> default:
> - pm_runtime_get_sync(port->dev);
> + ret = pm_runtime_get_sync(port->dev);
> + if (ret < 0)
> + dev_err(port->dev, "Failed to enable clocks\n");
So you just ignore the error? SHouldn't you propagate it back upward?
thanks,
greg k-h
