On Fri, Apr 29, 2022 at 03:33:00PM +0300, Ilpo Järvinen wrote: > On Fri, 29 Apr 2022, Greg KH wrote: > > > On Fri, Apr 29, 2022 at 02:57:16PM +0300, Ilpo Järvinen wrote: > > > The driver must provide throttle and unthrottle in uart_ops when it > > > sets UPSTAT_AUTORTS. Add them using existing stop_rx & > > > enable_interrupts functions. > > > > > > Compile tested (w/o linking). > > > > That shouldn't be here at all, put it below the --- line if its needed. > > > > > > > > > > Reported-by: Nuno Gonçalves <nunojpg@xxxxxxxxx> > > > Fixes: 2a76fa283098 (serial: pl011: Adopt generic flag to store auto > > > RTS status) > > > > Nit, this should be all in one line. > > > > > Cc: Lukas Wunner <lukas@xxxxxxxxx> > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > > > Any reason why you are not cc:ing all the needed people as per > > scripts/get_maintainer.pl? > > Yes there is ;-). Around here I'm being told that I should generally > avoid as much as possible bugging you unnecessarily. ...Or sending garbage > to you which I feel a compile tested patch for hw I'm not particularly > familiar with surely could be. After all this should be tested first and > then I'd be resending another version with Tested-by: xx Cc'ing you > and you would avoid all those intermediate garbage versions :-). As you can tell, I do see these patches and get concerned when you don't want the subsystem maintainers to review them. And our tools can pick up the tested-by lines just fine. If you don't want us to apply them, then use RFC and I will gladly ignore it. thanks, greg k-h
