On Tue, May 3, 2022 at 10:12 AM Jiri Slaby <jslaby@xxxxxxx> wrote: > > 'count' is zero in the pop_tx()'s comparison against 'size'. So the 'if' > tries to find out if 'size' is negative or zero and returns in that > case. But it cannot be negative, due to previous (size < 0) check in the > caller: handle_tx(). > > So simply move this check from pop_tx() to handle_tx(). Now it's clear > that pop_tx() is called only if fifo_size is non-zero. I'm in favour of the series, but ideally this driver should be converted to be a part of the 8250 family. -- With Best Regards, Andy Shevchenko
