Hi Shimoda-san, On Mon, Apr 25, 2022 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Add initial support for the Renesas R8A779G0 (R-Car V4H) SoC. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > + soc: soc { > + hscif0: serial@e6540000 { > + compatible = "renesas,hscif-r8a779g0", > + "renesas,rcar-gen4-hscif", > + "renesas,hscif"; > + reg = <0 0xe6540000 0 96>; > + interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>; 245 > + clocks = <&cpg CPG_MOD 514>, > + <&cpg CPG_CORE R8A779G0_CLK_S0D3_PER>, > + <&scif_clk>; > + clock-names = "fck", "brg_int", "scif_clk"; > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; > + resets = <&cpg 514>; > + status = "disabled"; > + }; The rest LGTM, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds