On Tue, Apr 19, 2022 at 10:38 AM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote:
> On 19. 04. 22, 9:29, Yu Tu wrote:
> > On 2022/4/18 20:09, Andy Shevchenko wrote:
> >> On Mon, Apr 18, 2022 at 8:50 AM Yu Tu <yu.tu@xxxxxxxxxxx> wrote:
...
> >>> +struct meson_uart_data {
> >>> + bool has_xtal_div2;
> >>
> >> I would prefer to see this as an unsigned int and with a less
> >> particular name, e.g. xtal_div would suffice.
> > I don't have a problem with your suggestion.Let's see What Neil has to say.
>
> Actually why uint provided it's a boolean value? Or do you mean to store
> the divisor directly in this member, Andy?
Yes I was thinking to provide the value and then always provide the
private data. In such cases we don't need an additional condition.
--
With Best Regards,
Andy Shevchenko
