On Thu, Mar 31, 2022 at 08:11:42AM +0100, Maciej W. Rozycki wrote: > The EndRun PTP/1588 dual serial port device is based on the Oxford > Semiconductor OXPCIe952 UART device with the PCI vendor:device ID set > for EndRun Technologies and uses the same sequence to determine the > number of ports available. Despite that we have duplicate code > specific to the EndRun device. > > Remove redundant code then and factor out OxSemi Tornado device > detection. Also correct the baud base like with commit 6cbe45d8ac93 > ("serial: 8250: Correct the clock for OxSemi PCIe devices") for the > value of 3906250 rather than 4000000, obtained by dividing the 62.5MHz > clock input by the default oversampling rate of 16. Finally move the > EndRun vendor:device ID to <linux/pci_ids.h>. That's a lot of different things happening all the same commit. Please break this out into one-patch-per-logical-change as is required. thanks, greg k-h