On Mon, Apr 11, 2022 at 11:33:20AM +0300, Ilpo Järvinen wrote: > Use 32-bit reads in order to not lose higher bits of DW > UART regs. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Maybe it needs an additional words that currently the driver doesn't use anything from the upper bits, that's why it's not a fix. > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_lpss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c > index 0f5af061e0b4..4ba43bef9933 100644 > --- a/drivers/tty/serial/8250/8250_lpss.c > +++ b/drivers/tty/serial/8250/8250_lpss.c > @@ -330,7 +330,7 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id) > uart.port.irq = pci_irq_vector(pdev, 0); > uart.port.private_data = &lpss->data; > uart.port.type = PORT_16550A; > - uart.port.iotype = UPIO_MEM; > + uart.port.iotype = UPIO_MEM32; > uart.port.regshift = 2; > uart.port.uartclk = lpss->board->base_baud * 16; > uart.port.flags = UPF_SHARE_IRQ | UPF_FIXED_PORT | UPF_FIXED_TYPE; > -- > 2.30.2 > -- With Best Regards, Andy Shevchenko
