* Johan Hovold <johan@xxxxxxxxxx> [220411 10:10]:
> On Mon, Apr 11, 2022 at 12:48:05PM +0300, Tony Lindgren wrote:
> > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> > --- a/drivers/tty/serial/8250/8250_port.c
> > +++ b/drivers/tty/serial/8250/8250_port.c
> > @@ -1677,8 +1677,10 @@ static void serial8250_start_tx(struct uart_port *port)
> >
> > serial8250_rpm_get_tx(up);
> >
> > - if (!port->x_char && uart_circ_empty(&port->state->xmit))
> > + if (!port->x_char && uart_circ_empty(&port->state->xmit)) {
> > + serial8250_rpm_put_tx(up);
> > return;
> > + }
>
> Move this before the runtime pm get instead?
Yup good idea.
Tony
