On Mon, Apr 04, 2022 at 10:27:30AM -0300, Wander Costa wrote: > On Mon, Apr 4, 2022 at 6:32 AM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Apr 01, 2022 at 04:46:42PM -0300, Wander Lairson Costa wrote: ... > > > + use_fifo = (up->capabilities & UART_CAP_FIFO) && > > > + /* > > > + * BCM283x requires to check the fifo > > > + * after each byte. > > > + */ > > > + !(up->capabilities & UART_CAP_MINI) && > > > > Perhaps you need to also comment why we are using tx_loadsz and not fifosize. > > Maybe it is better to document their difference in the struct > declaration and not in a random usage. Here, when one reads a code (as a non-familiar with the area), the use of tx_loadsz confuses if one saw previously fifosize used somewhere. So, I agree that it's good to document in the structure, but here it's also good to have a comment to briefly hint the reader why this and not the other one is used. -- With Best Regards, Andy Shevchenko
