On Thu, Mar 10, 2022 at 08:01:01PM +0100, Miquel Raynal wrote: > andriy.shevchenko@xxxxxxxxxxxxxxx wrote on Thu, 10 Mar 2022 20:02:41 > +0200: > > On Thu, Mar 10, 2022 at 05:16:46PM +0100, Miquel Raynal wrote: > > > From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> ... > > > +#include <linux/of_device.h> > > > > > + const struct dw8250_platform_data *plat = of_device_get_match_data(up->port.dev); > > > > No. Please use device property APIs. > > Are you suggesting the use of CPR DT property? If yes, what is the > point if there is one CPR per SoC? I would argue that DT description is > already quite complex and supporting one or another register is up to > the OS as long as we can map CPR registers to SoCs? I'm suggesting to use device property APIs, I'm not talking about ABI. In this case instead of above you may simply do #include <linux/property.h> const struct dw8250_platform_data *plat = device_get_match_data(up->port.dev); -- With Best Regards, Andy Shevchenko
