Hi Rafał, On Thu, Mar 10, 2022 at 11:13 PM Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > Patches lowering SERIAL_BCM63XX dependencies led to a discussion and > documentation change regarding "depends" usage. Adjust Kconfig entry to > match current guidelines. Make this symbol available for relevant > architectures only. > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies") > Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises") > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > --- > V2: Use precise "depends" (exact platforms) Thanks for the update! > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE > config SERIAL_BCM63XX > tristate "Broadcom BCM63xx/BCM33xx UART support" > select SERIAL_CORE > - depends on COMMON_CLK > + depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST > + default y Merely enabling COMPILE_TEST should not enable additional drivers. > help > This enables the driver for the onchip UART core found on > the following chipsets: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds