On Thu, Mar 10, 2022 at 05:16:45PM +0100, Miquel Raynal wrote:
> From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
>
> This structure needs to be reused from dwlib, so let's move it into a
> shared header. There is no functional change.
...
> +struct dw8250_data {
> + struct dw8250_port_data data;
> + u8 usr_reg;
I believe types.h is already in the inclusion block.
> + int msr_mask_on;
> + int msr_mask_off;
> + struct clk *clk;
> + struct clk *pclk;
Do you need forward declarations?
> + struct notifier_block clk_notifier;
> + struct work_struct clk_work;
I haven't seen the change in the inclusion block.
Don't you miss necessary headers?
> + struct reset_control *rst;
Do you need forward declaration?
> + unsigned int skip_autocfg:1;
> + unsigned int uart_16550_compatible:1;
> +};
--
With Best Regards,
Andy Shevchenko
