On 07/03/2022 21:24, Andy Shevchenko wrote:
> On Mon, Mar 7, 2022 at 11:20 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>>
>> Simplify the code with of_device_get_match_data().
>
> You may get rid of ugly ifdeffery as well.
>
> ...
>
>> static inline const struct s3c24xx_serial_drv_data *
>> s3c24xx_get_driver_data(struct platform_device *pdev)
>> {
>> #ifdef CONFIG_OF
>> - if (pdev->dev.of_node) {
>> - const struct of_device_id *match;
>> -
>> - match = of_match_node(s3c24xx_uart_dt_match, pdev->dev.of_node);
>> - return (struct s3c24xx_serial_drv_data *)match->data;
>> - }
>
>> + if (pdev->dev.of_node)
>
> I believe it's never true when CONFIG_OF=n,
Right, I can use dev_of_node() helper for that purpose as well. Thanks!
Best regards,
Krzysztof
