On Sun, 6 Mar 2022, Lukas Wunner wrote:
> On Wed, Mar 02, 2022 at 11:56:01AM +0200, Ilpo Järvinen wrote:
> > @@ -110,9 +110,14 @@ static int dw8250_rs485_config(struct uart_port *p, struct serial_rs485 *rs485)
> >
> > if (rs485->flags & SER_RS485_ENABLED) {
> > /* Clearing unsupported flags. */
> > - rs485->flags &= SER_RS485_ENABLED;
> > -
> > - tcr |= DW_UART_TCR_RS485_EN | DW_UART_TCR_XFER_MODE_DE_OR_RE;
> > + rs485->flags &= SER_RS485_ENABLED | SER_RS485_RX_DURING_TX;
> > + tcr |= DW_UART_TCR_RS485_EN;
> > +
> > + if (rs485->flags & SER_RS485_RX_DURING_TX) {
> > + tcr |= DW_UART_TCR_XFER_MODE_DE_DURING_RE;
> > + } else {
> > + tcr |= DW_UART_TCR_XFER_MODE_DE_OR_RE;
> > + }
>
> This patch deletes lines introduced by the preceding patch.
> I'd just squash the two together, I don't see much value in
> introducing full duplex support in a separate patch.
Sure, I can merge them.
--
i.
